-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: impl Trait desugaring in trait objects' assoc constraints #97335
Conversation
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
r? @cjgillot |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #97598) made this pull request unmergeable. Please resolve the merge conflicts. |
ty.span, | ||
), | ||
ImplTraitContext::Universal(item_def) => { | ||
//| ImplTraitContext::UniversalInDyn(item_def) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//| ImplTraitContext::UniversalInDyn(item_def) => { | |
| ImplTraitContext::UniversalInDyn(item_def) => { |
This is the correct behaviour here.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #98106) made this pull request unmergeable. Please resolve the merge conflicts. |
@randomicon00 what's the status of this? |
@Dylan-DPC Will have an update in the next two weeks. |
@randomicon00 any updates on this? |
Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks |
Issue: #96529
Right now, the tasks that are done:
impl_trait_id
torust_ast::AssocConstraint
.In progress:
The next tasks are a break out of what I am trying to accomplish. A bit different from the original tasks in order to be as precise as possible and help with mentoring.
visit_assoc_constraint
indef_collector
and create the local def id there by matching withUniversalInDyn
context.desugar_to_impl_trait
with the associated constraint check.rust_ast_lowering::ImplTraitContext
and add the vector toLoweringContext
.with_hir_id_owner
.Not started yet.
ResolverAstLowering::get_impl_trait_context(LocalDefId)
to access theImplTraitContext
value.lower_fn_decl
.